There are still and always will be good investments in Spain
Most people buying are doing so as a Life Style choice and the increase in value they get [ like buying your home in UK] is a bonus
You get more for your money say between Alicante and Mojacar compared with Algarve and the weather is much better in winter and cheaper living

Good developments do not have to make ' give away offers' to get buyers and for example guaranteed rentals are already included in the price you pay.....just compare the price per m2 with a GR and one without !!!
But it is an atrractive gamble for some
Love Algarve and first went there in 1974 but for anything decent now it is too expensive for a lot of ordinary people